On Thu, 13 May 2021 18:53:25 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright typo
>
> test/jdk/tools/jmod/hashes/HashesTest.java line 90:
>
>> 88: }
>> 89: this.mods = dest.resolve("mods");
>> 90: Path srcDir = dest.resolve("src");
>
> you can just get rid of this local variable and do this in line 92:
>
> this.builder = new ModuleInfoMaker(dest.resolve("src"));
Yes I can do that and realized that after I pushed the update
> test/jdk/tools/jmod/hashes/HashesTest.java line 387:
>
>> 385: if (hashes != null) {
>> 386: hashes.names().stream().sorted().forEach(n ->
>> 387: System.out.format(" %s %s%n", n,
>> toHex(hashes.hashFor(n)))
>
> Nit: the extra whitespaces in line 384 and 387 may be added by IDE. Can you
> revert it.
Intellij did that. I can tweak
-------------
PR: https://git.openjdk.java.net/jdk/pull/4009
