On Thu, 27 May 2021 15:02:01 GMT, Aleksei Efimov <aefi...@openjdk.org> wrote:
> Hi, > > `com/sun/jndi/dns/ConfigTests/Timeout.java ` was seen failing intermittently > with "Address already in use" `BindException`. The reason of this failure is > that `disconnect` call in JNDI `DnsClient` fails to rebind the datagram > socket to the original port during `disconnect` call (the failure is in > `DatagramChannel::repairSocket`). > Since Datagram socket is not reused and closed after the failure `finally` > block with the `disconnect` call can be removed. > > The fix was tested with all available JNDI/DNS tests, and no failures related > to the change were observed. LGTM. I really wish git had a better `diff` ! Can you add `@bug 8265309` to com/sun/jndi/dns/ConfigTests/Timeout.java since this is a product change? ------------- Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4227
