On Mon, 31 May 2021 10:25:26 GMT, Xiaohong Gong <xg...@openjdk.org> wrote:
> Currently `"VectorMask.eq()" `is not vectorized:
>
> public VectorMask<E> eq(VectorMask<E> m) {
> // FIXME: Generate good code here.
> return bOp(m, (i, a, b) -> a == b);
> }
>
> This can be implemented by calling `"xor(m.not())"` directly.
>
> The performance improved about 1.4x ~ 1.9x for the following benchmark with
> different basic types:
>
> @Benchmark
> public Object eq() {
> boolean[] ma = fm.apply(size);
> boolean[] mb = fmb.apply(size);
> boolean[] mt = fmt.apply(size);
> VectorMask<Byte> m = VectorMask.fromArray(SPECIES, mt, 0);
>
> for (int ic = 0; ic < INVOC_COUNT; ic++) {
> for (int i = 0; i < ma.length; i += SPECIES.length()) {
> var av = SPECIES.loadMask(ma, i);
> var bv = SPECIES.loadMask(mb, i);
>
> // accumulate results, so JIT can't eliminate relevant
> computations
> m = m.and(av.eq(bv));
> }
> }
>
> return m;
> }
This pull request has now been integrated.
Changeset: 496fb90b
Author: Xiaohong Gong <xg...@openjdk.org>
Committer: Nils Eliasson <nelia...@openjdk.org>
URL:
https://git.openjdk.java.net/jdk/commit/496fb90b3a038f5fe76acc8a98bcd0dac4071cf9
Stats: 254 lines in 32 files changed: 248 ins; 6 del; 0 mod
8267969: Add vectorized implementation for VectorMask.eq()
Reviewed-by: psandoz, neliasso
-------------
PR: https://git.openjdk.java.net/jdk/pull/4272
