On Thu, 3 Jun 2021 17:04:58 GMT, Mandy Chung <[email protected]> wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268124: small refactoring; fixed misplaced comment and added missing
>> lambda operator
>
> src/java.base/share/classes/java/lang/constant/DirectMethodHandleDescImpl.java
> line 138:
>
>> 136: public String lookupDescriptor() {
>> 137: return switch (kind) {
>> 138: case VIRTUAL, SPECIAL,
>
> Nit: I prefer to have each case in a separate line (in this switch and also
> the switch in `resolveConstantDesc`.
Hi Mandy. Thanks for your suggestion. I've now moved each case onto its own
line. Please see ccc9db7 / df5b34e
-------------
PR: https://git.openjdk.java.net/jdk/pull/4312