On Thu, 22 Apr 2021 13:47:03 GMT, ScientificWare <github.com+19194678+scientificw...@openjdk.org> wrote:
> This concerns [dtdbuilder > tools](https://github.com/openjdk/jdk/tree/master/make/jdk/src/classes/build/tools/dtdbuilder). > > In jshell, try `System.getProperty("html32") + ""` you'll get a `String`. > > So, in `DTDBuilder.java` when none `dtd_home` property is set, the `dtd_home` > string value is not `null`, causing an exception with the present test. > > The expected value is `"Must set property 'dtd_home'"` > > And in this case, should'nt we have a `System.exit(1)` too rather than a > simple `return` ? This pull request has now been integrated. Changeset: 49112fa5 Author: ScientificWare <i...@scientificware.com> Committer: Erik Joelsson <er...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/49112fa5752174a77fb5cd276fdd4240bf76bf82 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod 8265909: build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home Reviewed-by: erikj ------------- PR: https://git.openjdk.java.net/jdk/pull/3626
