On Wed, 16 Jun 2021 10:57:07 GMT, Patrick Concannon <[email protected]>
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.time`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new target base due to
> a merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains four additional
> commits since the last revision:
>
> - 8268469: Removed excessive spacing; corrected misplaced comments
> - Merge remote-tracking branch 'origin/master' into JDK-8268469
> - Merge remote-tracking branch 'origin/master' into JDK-8268469
> - 8268469: Update java.time to use switch expressions
src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line
2793:
> 2791: case NOT_NEGATIVE -> throw new
> DateTimeException("Field " + field +
> 2792: " cannot be
> printed as the value " + value +
> 2793: " cannot be
> negative according to the SignStyle");
Maybe in this case you could revert the alignment. In this case it would allow
lines 2792 to 2793 to be shorter
-------------
PR: https://git.openjdk.java.net/jdk/pull/4433
