On Sun, 30 May 2021 17:30:56 GMT, Markus KARG <github.com+1701815+mk...@openjdk.org> wrote:
> This PR-*draft* is **work in progress** and an invitation to discuss a > possible solution for issue > [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not > yet* intended for a final review. > > As proposed in JDK-8265891, this PR provides an implementation for > `Channels.newInputStream().transferTo()` which provide superior performance > compared to the current implementation. The changes are: > * Prevents transfers through the JVM heap as much as possibly by offloading > to deeper levels via NIO, hence allowing the operating system to optimize the > transfer. > * Using more JRE heap in the fallback case when no NIO is possible (still > only KiBs, hence mostl ynegligible even on SBCs) to better perform on modern > hardware / fast I/O devides. > > Using JMH I have benchmarked both, the original implementation and this > implementation, and (depending on the used hardware and use case) performance > change was approx. doubled performance. So this PoC proofs that it makes > sense to finalize this work and turn it into an actual OpenJDK contribution. > > I encourage everybody to discuss this draft: > * Are there valid arguments for *not* doing this change? > * Is there a *better* way to improve performance of > `Channels.newInputStream().transferTo()`? > * How to go on from here: What is missing to get this ready for an actual > review? @AlanBateman I'm done with the changes you requested and kindly like to ask where to go from here. Great ideas, will do as you say, stay tuned! Didn't know that using `var` is a no-go, sorry for that. Pattern matching is definitively a great idea! Replaced `var` by actual type in https://github.com/openjdk/jdk/pull/4263/commits/b3c62b0951124550a686386b9419f7246c214dc6. Replaced casting by pattern matching for `instanceof` in https://github.com/openjdk/jdk/pull/4263/commits/ac62cdb9acffc133bfaaa97ee77d5c7b3b704994. There had been no more comments since one week. How to proceed? As there had been no more change requests within one week, I assume this means you all rate this PR as read-to-review, so hereby I change its state and explicitly invite everybody to review this proposal. :-) ------------- PR: https://git.openjdk.java.net/jdk/pull/4263
