On Thu, 17 Jun 2021 16:13:49 GMT, Joe Wang <jo...@openjdk.org> wrote:
> The issue was that the attribute was processed before the variable was set
> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
Looks good overall. Some minor comments in the test.
test/jaxp/javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java line
206:
> 204: * source and expected output
> 205: */
> 206: @DataProvider(name = "preserveSpace")
You would not need the name, since the default name is the DataProvider method
name.
test/jaxp/javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java line
207:
> 205: */
> 206: @DataProvider(name = "preserveSpace")
> 207: public Object[][] preserveSpace() throws Exception {
`throws Exception` may be eliminated.
test/jaxp/javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java line
220:
> 218: * @param xml the source
> 219: * @param expected the expected result
> 220: * @throws Exception if the test fails
`Exception` is thrown from `transform` method. So the description is not wrong,
but it may imply the objective of this test failed, i.e. the result of
`assertEquals()`.
-------------
PR: https://git.openjdk.java.net/jdk17/pull/89
