On Tue, 27 Jul 2021 15:52:23 GMT, Alan Bateman <[email protected]> wrote:
>> Thank you for reviving the discussion.
>>
>> I have not gone through the latest update in detail but there are some
>> changes that are needed. Before moving forward with the CSR, I would like to
>> give time for additional feedback on naming and design.
>>
>> I am not sure the builder names withXXX are the preferred naming pattern.
>
>> I have not gone through the latest update in detail but there are some
>> changes that are needed. Before moving forward with the CSR, I would like to
>> give time for additional feedback on naming and design.
>
> This proposal will need a few iterations to get to the right API. There are
> several issues with the proposed GZIPHeaderBuilder, also GZIPHeaderData is
> mutable (having byte[] as elements in a record is a hazard). I will try to
> make time in the coming weeks to help.
Dear @AlanBateman and @LanceAndersen,
Sorry for late response, and really appreciated for your help on looking at
this PR. I will update the pr based on Lance's comments first. Thanks!
Lin
-------------
PR: https://git.openjdk.java.net/jdk/pull/3072
