Dear Lance, OK, Thanks for your reviewing and effort! BRs, Lin From: Lance Andersen <lance.ander...@oracle.com> Date: Monday, August 2, 2021 at 11:43 PM To: Lin Zang <lz...@openjdk.java.net> Cc: "core-libs-dev@openjdk.java.net" <core-libs-dev@openjdk.java.net> Subject: [Internet]Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v9]
On Aug 2, 2021, at 10:39 AM, Lin Zang <lz...@openjdk.java.net<mailto:lz...@openjdk.java.net>> wrote: On Tue, 27 Jul 2021 15:52:23 GMT, Alan Bateman <al...@openjdk.org<mailto:al...@openjdk.org>> wrote: Thank you for reviving the discussion. I have not gone through the latest update in detail but there are some changes that are needed. Before moving forward with the CSR, I would like to give time for additional feedback on naming and design. I am not sure the builder names withXXX are the preferred naming pattern. I have not gone through the latest update in detail but there are some changes that are needed. Before moving forward with the CSR, I would like to give time for additional feedback on naming and design. This proposal will need a few iterations to get to the right API. There are several issues with the proposed GZIPHeaderBuilder, also GZIPHeaderData is mutable (having byte[] as elements in a record is a hazard). I will try to make time in the coming weeks to help. Dear @AlanBateman and @LanceAndersen, Sorry for late response, and really appreciated for your help on looking at this PR. I will update the pr based on Lance's comments first. Thanks! Hi Lin, I would hold off on updates to the PR until Alan has a chance to provide his input. I have not yet had time to go through everything outside of the very quick pass I made earlier. Best Lance Lin ------------- PR: https://git.openjdk.java.net/jdk/pull/3072 [cid:image001.gif@01D787F9.EF1164E0] Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com<mailto:lance.ander...@oracle.com>
