On Mon, 16 Aug 2021 23:31:41 GMT, Mikhailo Seledtsov <mseledt...@openjdk.org>
wrote:
> Please review this change that updates the buildJdkDockerImage() test library
> API.
>
> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
> support for containers is not tested".
> The initial intent was to extend the buildJdkDockerImage() API of
> DockerTestUtils to accept custom Dockerfile content.
> As I analyzed the usage of buildJdkDockerImage() I realized that:
> - 2nd argument "dockerfile" is always the same: "Dockerfile-BasicTest"
> its use has been obsolete for some time, in favor of Dockerfile
> generated by DockerTestUtils
> - 3rd argument "buildDirName" is also always the same: "jdk-docker"
>
> Hence I thought it would be a good idea to simplify this API and make it
> up-to-date.
>
> Also, since the method signature is being updated, I thought it would be a
> good idea to also change the name to use more generic container terminology:
> buildJdkDockerImage() --> buildJdkContainerImage()
@hseigel Could you please review when you have a chance ?
Testing:
- ran jdk/containers and hotspot/containers tests on
- OL 7.9 with Docker
- OL 8.3 with Podman
- OL 8.3 aarch64 with Podman
All PASS
-------------
PR: https://git.openjdk.java.net/jdk/pull/5134
