On Tue, 24 Aug 2021 20:49:52 GMT, Sandhya Viswanathan
<[email protected]> wrote:
>> This pull request adds a micro benchmark for Vector API.
>> The Black Scholes algorithm is implemented with and without Vector API.
>> We see about ~6x gain with Vector API for this micro benchmark using 256 bit
>> vectors.
>
> Sandhya Viswanathan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Make constants as static final
Very nice, just one minor comment (no need for another review), thanks for
contributing this.
test/micro/org/openjdk/bench/jdk/incubator/vector/BlackScholes.java line 60:
> 58:
> 59: float randFloat(float low, float high) {
> 60: float val = rand.nextFloat()/Float.MAX_VALUE;
`nextFloat` returns a PSR between 0 and 1., so no need to divide by
`Float.MAX_VALUE` ?
-------------
Marked as reviewed by psandoz (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5234
