On Wed, 25 Aug 2021 17:53:52 GMT, Sergei Ustimenko <github.com+5709644+fd...@openjdk.org> wrote:
>> Change #3294 helps to avoid `AnnotaionFormatException` in >> `sun.reflect.annotation.AnnotationInvocationHandler.validateAnnotationMethods`. >> While it fixes the case with e.g. `Runnable` that generates the synthetic >> method without parameters, validation still fails on synthetic methods that >> have parameters e.g. `Function`, `BiFunction`, etc. >> >> This change removes the restriction on parameters count to be zero i.e. >> lambdas with parameters >> would be skipped from validation. > > Sergei Ustimenko has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - 8268788: Filter out synthetic methods from the member methods computation > - 8268788: Annotations with lambda expressions can still cause > AnnotationFormatError Hello, Thanks for the refined PR. Doing another round of review remain on my to-do list. -Joe ------------- PR: https://git.openjdk.java.net/jdk/pull/4642
