On Tue, 7 Sep 2021 15:53:20 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:

>> test/jdk/java/foreign/TestMatrix.java line 7:
>> 
>>> 5:  * @build NativeTestHelper CallGeneratorHelper TestUpcallHighArity
>>> 6:  *
>>> 7:  * @run testng/othervm/native
>> 
>> can you please throw in a `/manual` in here as well - so that this test will 
>> be disabled when running tests with jtreg `-a` option (which should be the 
>> norm in headless mode).
>
> I can, but it seems to me that `/manual` is for marking GUI tests that 
> require user interaction. Let me see if there are keywords we can use. 
> Something like "developer", so that you can pass `jtreg -k:developer` or 
> `JTREG_KEYWORDS=developer make test ...` when you really want to run them. 
> I'll take a closer look tomorrow.

you are right about /manual being for GUI - but @AlanBateman pointed me at few 
tests with libzip using it for similar reasons (e.g. long running tests).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5358

Reply via email to