On Thu, 9 Sep 2021 08:31:30 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   update javadoc to match latest changes
>
> Hello Magnus,
> 
>> Am I the only one thinking there should also be a way for developers to 
>> explicitly disable timestamps from the API?
>> 
>> I think the current iteration looks okay (but the core-libs guys of course 
>> has the say in this), but I still think we need a new method (or overload) 
>> to allow for a timestamp-free to be generated, always, independent of 
>> environment variables.
> 
> I decided to take this comment to the mailing list[1] where the proposal for 
> this change was discussed, since it's likely more people will be watching 
> that thread than this RFR thread.
> 
> [1] 
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-September/081305.html

@jaikiran Thanks for following this through all the twists and turns. The 
review thread here is pretty long, but I think we've made a lot of progress and 
are close to converging. In addition, the code keeps getting simpler, so that's 
a good thing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5372

Reply via email to