On Fri, 17 Sep 2021 01:52:30 GMT, Mandy Chung <mch...@openjdk.org> wrote:

>> Remilia Scarlet has refreshed the contents of this pull request, and 
>> previous commits have been removed. The incremental views will show 
>> differences compared to the previous content of the PR. The pull request 
>> contains one new commit since the last revision:
>> 
>>   8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on 
>> supported 64-bit platforms
>
> test/jdk/tools/jlink/plugins/CDSPluginTest.java line 84:
> 
>> 82:         }
>> 83: 
>> 84:        // Simulate different platforms between current runtime and 
>> target image.
> 
> The above change checking 64-bit platform should not be needed.    On an 
> unknown platform, `isDefaultCDSArchiveSupported` should return false.  It 
> only returns true on 64-bit supported platforms.   Can you verfiy?

I just try it on LoongArch64 and mips64el.

The `Platform.isDefaultCDSArchiveSupported()` returns true.
So the above checking can not be removed.

Also, I just forgot add `import jtreg.SkippedException`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5519

Reply via email to