On Wed, 22 Sep 2021 15:00:59 GMT, Roger Riggs <rri...@openjdk.org> wrote:
> The Mac OS specific code to determine the os.version property in > java_props_macosx.c is updated > to replace the code extracting the version from the SystemVersion.plist by > reading the version using t\ > he hidden link: src/java.base/macosx/native/libjava/java_props_macosx.c line 270: > 268: > @"/System/Library/CoreServices/.SystemVersionPlatform.plist"]; > 269: if (version != NULL) { > 270: NSString *nsVerStr = [version objectForKey : > @"ProductVersion"]; Should we check `nsVerStr != NULL` here? ------------- PR: https://git.openjdk.java.net/jdk/pull/5633