On Mon, 27 Sep 2021 18:40:10 GMT, Joe Darcy <da...@openjdk.org> wrote:
> Follow-up change to JDK-8232230, augmentations to javac's Xlint:serial > checking are out for review (https://github.com/openjdk/jdk/pull/5709) and > java.util.concurrent would need some changes to pass under the expanded > checks. > > The changes are to suppress warnings where non-transient fields in > serializable types are not declared with a type statically known to be > serializable. That isn't necessarily a correctness issues, but it does merit > further scrutiny. > > In ForkJoinTask, the SuppressWarnings annotation previously applied in > JDK-8232230, seems to have been misplaced to a different field; this change > corrects it. Just to be sure, does this include only the conditionally serializable annotations in ForkJoinPool and ForkJoinTask in: https://github.com/openjdk/jdk/pull/5718/files/a20d9afbd7b49b452b3c9bdc9f2d56442b5e2fc6 If so, this looks OK to me. ------------- PR: https://git.openjdk.java.net/jdk/pull/5718
