On Fri, 16 Apr 2021 11:30:32 GMT, Raffaello Giulietti <d...@openjdk.java.net> wrote:
>> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about >> multi-line (block) comments. Nothing in the code proper has changed, except >> for the addition of redundant but clarifying parentheses in some expressions. >> >> >> Greetings >> Raffaello > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 4511638: Double.toString(double) sometimes produces incorrect results (Guy Steele reply to a previous comment of mine) Yes, thank you, I stated my suggested criterion incorrectly. —Guy On Oct 11, 2021, at 4:16 AM, Raffaello Giulietti ***@***.******@***.***>> wrote:> Hi Guy, > > while implementing the additional test recommended in your point (2), it > occurred to me that the numbers of the form y 10^n, y in D_k (k = 1, 2, 3, 4) > end up being of the form y' 10^n', where y' = y / 10^k, n' = n + k, plus the > 2 * Y values around these. Such numbers do not seem to show any special > structure worth a dedicated test, so I'm wondering if you mean something else > instead. > > Perhaps you mean y to have at most 4 digits, i.e., 0 <= y < 10^4? > > Greetings > Raffaello > > P.S. The test recommended in point (1) pass successfully. > ------------- PR: https://git.openjdk.java.net/jdk/pull/3402
