On Wed, 13 Oct 2021 23:49:19 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor cleanup. Improve javadoc in CallerSensitiveAdapter
>
> src/java.base/share/classes/jdk/internal/reflect/DirectMethodHandleAccessor.java
> line 58:
>
>> 56: * Creates a MethodAccessorImpl for a caller-sensitive method.
>> 57: */
>> 58: static MethodAccessorImpl callerSensitiveMethodAccessor(Method
>> method, MethodHandle dmh) {
>
> This method and the one above are identical - they just call `new
> DirectMethodHandleAccessor` with same parameters. Is the distinction between
> these two factories still relevant? (besides the different asserts)
Good catch! It no longer needs this distinction in this new version. Will
remove it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5027
