On Fri, 15 Oct 2021 21:04:12 GMT, Vamsi Parasa <d...@openjdk.java.net> wrote:

> > > How you verified correctness of results? I suggest to extend 
> > > `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover 
> > > unsigned method.
> > 
> > 
> > Tests for unsignedMultiplyHigh were already added in 
> > test/jdk//java/lang/Math/MultiplicationTests.java (in July 2021 by Brian 
> > Burkhalter). Used that test to verify the correctness of the results.
> 
> Good. It seems I have old version of the test. Did you run it with -Xcomp? 
> How you verified that intrinsic is used?

I have verified that the intrinsic is being used by looking at the x86 assembly 
code generated by using perfasm profiler.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5933

Reply via email to