On Sat, 16 Oct 2021 00:56:14 GMT, Paul Sandoz <psan...@openjdk.org> wrote:

>> This PR improves the performance of vector operations that accept masks on 
>> architectures that support masking in hardware, specifically Intel AVX512 
>> and ARM SVE.
>> 
>> On architectures that do not support masking in hardware the same technique 
>> as before is applied to most operations, specifically composition using 
>> blend.
>> 
>> Masked loads/stores are a special form of masked operation that require 
>> additional care to ensure out-of-bounds access throw exceptions. The range 
>> checking has not been fully optimized and will require further work.
>> 
>> No API enhancements were required and only a few additional tests were 
>> needed.
>
> Paul Sandoz has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains seven commits:
> 
>  - Merge branch 'master' into JDK-8271515-vector-api
>  - Apply patch from https://github.com/openjdk/panama-vector/pull/152
>  - Apply patch from https://github.com/openjdk/panama-vector/pull/142
>  - Apply patch from https://github.com/openjdk/panama-vector/pull/139
>  - Apply patch from https://github.com/openjdk/panama-vector/pull/151
>  - Add new files.
>  - 8271515: Integration of JEP 417: Vector API (Third Incubator)

The Java changes look good to me.

src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMask.java 
line 574:

> 572:      * @throws ClassCastException if the species is wrong
> 573:      */
> 574:     abstract <F> VectorMask<F> check(Class<? extends VectorMask<F>> 
> maskClass, Vector<F> vector);

This is a package-private method so the java doc style comments are not needed 
here.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5873

Reply via email to