On Wed, 27 Oct 2021 14:08:05 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Mandy Chung has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 40 commits: >> >> - Fall back to the VM native reflection support if method handle cannot be >> created >> - fix bug id in test >> - Merge >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> reimplement-method-invoke >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> reimplement-method-invoke >> - Separate paramFlgas into paramCount and flags fields >> - Minor cleanup. Improve javadoc in CallerSensitiveAdapter >> - Fix left-over assignment >> - Remove duplicated microbenchmarks >> - Avoid pitfall with unwanted inlining in some cases. Also remove >> boxing/unboxing to focus on the invocation cost >> - ... and 30 more: >> https://git.openjdk.java.net/jdk/compare/97d3280e...64738bb2 > > src/java.base/share/classes/jdk/internal/reflect/AccessorUtils.java line 34: > >> 32: */ >> 33: public class AccessorUtils { >> 34: static boolean isIllegalArgument(Class<?> accessorType, >> RuntimeException e) { > > It might be useful to add a method description. In isolation, it's not > immediately clear what it does. I agree that'd be helpful. I'll add the javadoc. ------------- PR: https://git.openjdk.java.net/jdk/pull/5027
