On 28/10/2021 05:43, Jaikiran Pai wrote:
:
Hello Alan,
Looking at the CDS issue that's being tracked at
https://bugs.openjdk.java.net/browse/JDK-8275731, it's looking like a much
bigger change and might take a while. In the meantime do you think this test
case (and the fix to the hashCode() part) looks OK? I am open to deleting the
commented out equality check in this test case since although that equality
testing should be done, it doesn't have to be done as part of this hashCode()
fix/test PR. Let me know what you and others prefer.
I think it's okay to move to using the ordinal of the hash code. I think
the test will need a round or two of clean-up to get it more consistent
with the existing naming and style of tests in this area. I'd prefer
not have commented out "TODO" code if possible.
-Alan.
