On Tue, 2 Nov 2021 20:34:44 GMT, Martin Buchholz <mar...@openjdk.org> wrote:
>>> Pragmatically, fix the script to ignore those keywords on comment lines. >>> Learn Perl, its just a regular expression pattern match and replace >>> expression. >> >> I understand in principle how to modify that script to ignore doc comments. >> The thing I was referring to when said "btw, how would we do that?" was >> this: not all comment lines are prose. Some of those lines belong to >> snippets of code, which I guess you would also like to be properly formatted. >> >>> But having seen several reviewers be unmoved by the difference, the real >>> pragmatic view is to ignore the English. >> >> I'm sorry you feel that way. Would it be okay if I made it clear that those >> two words are not English adjectives but are special symbols that happen to >> use Latin script and originate from the English words they resemble? If so, >> I could enclose each of them in `{@code ... }`. If not, I could drop that >> particular change from this PR. > > The blessed-modifier-order.sh script intentionally modifies comments, with > the hope of finding code snippets (it did!) > > Probably I manually deleted the change to Object.java back in 2015, to avoid > the sort of controversy we're seeing now. > I don't have a strong feeling either way on changing that file. > > I agree with @pavelrappo that script-generated changes should not be mixed > with manual changes. > I would also not update copyright years for such changes. > > It's a feature of blessed-modifier-order.sh that all existing formatting is > perfectly preserved. One more thing. Please have a look at this other line in the same file; this line was there before the change https://github.com/openjdk/jdk/blob/465d350d0b3cac277a58b9f8ece196c1cde68e80/src/java.base/share/classes/java/lang/Object.java#L49 So before the change, the file was somewhat inconsistent. The change made it consistent. **If one is going to ever revert that controversial part of the change, please update both lines so that the file remains consistent.** ------------- PR: https://git.openjdk.java.net/jdk/pull/6213