On Tue, 16 Nov 2021 12:21:20 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a >> PrintStream to its charset. This issue was raised during the conversations >> in https://github.com/openjdk/jdk/pull/5771 >> A corresponding CSR has also been drafted: >> https://bugs.openjdk.java.net/browse/JDK-8277078 > > src/java.base/share/classes/java/io/PrintWriter.java line 139: > >> 137: * the charset in {@code out} if it is a {@code PrintStream}, or >> using >> 138: * the default charset. >> 139: * > > I think I prefer the wording in OutputStreamWriter because it puts the > default encoding first and makes it just a bit clearer that the PS case is > the exception. Will use `OutputStreamWriter`'s wording here. Also I am tempted to make `PrintStream::charset()` public, as some custom `OutputStreamWriter` implementations would also need the charset information. ------------- PR: https://git.openjdk.java.net/jdk/pull/6401
