On Wed, 24 Nov 2021 10:05:11 GMT, Alan Bateman <[email protected]> wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor fix to avoid casting
>
> src/jdk.jdeps/share/classes/com/sun/tools/jdeps/DependencyFinder.java line
> 277:
>
>> 275: throw (Error)t;
>> 276: } else {
>> 277: throw new Error(e);
>
> A minor suggestion is that you could avoid the casts with:
>
> Throwable cause = ...
> if (cause instanceof RuntimeException e) {
> throw e;
> } else if (cause instanceof Error e) {
> throw e;
> } else {
Fixed. Thanks for reminding.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6530