On Mon, 29 Nov 2021 16:22:30 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:
>> Add a new --source-date <TIMESTAMP> (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by: Andrew Leonard <anleo...@redhat.com>
>
> Andrew Leonard has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>
> Signed-off-by: Andrew Leonard <anleo...@redhat.com>
> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>
> Signed-off-by: Andrew Leonard <anleo...@redhat.com>
This is just a quick comment on the epoch date and time string. I'm testing
your updates on the JavaFX builds now and will follow up with the results and
more comments later today. Thanks, Andrew.
src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties line 88:
> 86: date {0} is not a valid ISO 8601 date and time
> 87: error.date.before.epoch=\
> 88: date {0} is before Epoch 1970-01-01T00:00:00
The epoch in Java is a [zoned date and time][1] (1970-01-01T00:00:00Z).
[1]:
https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Instant.html#EPOCH
-------------
Changes requested by jgneff (no project role).
PR: https://git.openjdk.java.net/jdk/pull/6481
