On Thu, 18 Nov 2021 19:09:18 GMT, Ravi Reddy <rre...@openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close 
>> operations on GZip we are not setting the deflator to a finished state which 
>> is leading to an infinite loop when we try writing on the same GZip 
>> instance( since we use while(!def.finished()) inside the write operation).
>> 
>> Thanks,
>> Ravi
>
> Ravi Reddy has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Added ZipException case to handle failure CopyZipFile.java - Only close the 
> deflater incase of IOException not in ZipException case scenario

could you move the test up one directory to java/util/zip ? I don't think it's 
particular to GZIP any longer. Also perhaps a rename to something like 
CloseDeflaterTest etc.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5522

Reply via email to