On Thu, 9 Dec 2021 18:15:42 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>> Signed-off-by: Andrew Leonard <anleo...@redhat.com>
>
> test/jdk/tools/jar/ReproducibleJar.java line 114:
>
>> 112: }
>> 113:
>> 114: @Test
>
> Please add a comment introducing the intent of the test. As mentioned above,
> please consider using a DataProvider vs. an array with the test.
done
> test/jdk/tools/jar/ReproducibleJar.java line 286:
>
>> 284:
>> 285: static void extractJar(File jarFile) throws Throwable {
>> 286: String javahome = System.getProperty("java.home");
>
> Please add a basic comment of the intent of the method.
>
> Any reason you chose not to use JAR_TOOL here?
done
-------------
PR: https://git.openjdk.java.net/jdk/pull/6481
