On Fri, 10 Dec 2021 16:31:45 GMT, Roman Kennke <rken...@openjdk.org> wrote:

>> As a follow-up to #6375, this change refactors 
>> java.io.ObjectInputStream.Caches#subclassAudits and 
>> java.io.ObjectOutputStream.Caches#subclassAudits to use ClassValue instead 
>> of SoftReference, similar to what we did in #6375 for 
>> java.io.ObjectStreamClass.Caches#localDescs. Then we can now also remove the 
>> common machinery java.io.ObjectStreamClass#processQueue and 
>> java.io.ObjectStreamClass.WeakClassKey.
>> 
>> Testing:
>>  - [x] tier1
>>  - [x] tier2
>>  - [ ] tier3
>
> Roman Kennke has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains eight commits:
> 
>  - 8278065: Refactor subclassAudits to use ClassValue
>  - Remove unused EntryFuture inner class from ObjectSteamClass
>  - Merge remote-tracking branch 'jdk-plevart/JDK-8277072-peter' into 
> JDK-8277072
>  - Use ClassValue to solve JDK-8277072
>  - Use ForceGC instead of System.gc()
>  - Convert test to testng
>  - Fix indentation of new testcase
>  - 8277072: ObjectStreamClass caches keep ClassLoaders alive

> Skara is failing to run jcheck on this PR. I think this is ultimately a bug 
> in Skara, that gets tickled by your source branch being quite far behind 
> jdk:master, in combination with 
> [62a7f5d](https://github.com/openjdk/jdk/commit/62a7f5d3236ab2248518a475b1d8b71cb4bf1313)
>  recently going in. If you merge jdk:master into your branch, I believe this 
> will resolve itself for now.

I've investigated further and filed 
https://bugs.openjdk.java.net/browse/SKARA-1281. Once fixed you would get an 
error message in this PR telling you to rebase your source branch.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6637

Reply via email to