On Wed, 15 Dec 2021 08:29:20 GMT, Сергей Цыпанов <d...@openjdk.java.net> wrote:

>>> @AlanBateman the benchmark is mine along with the changes for 
>>> `translateEscapes` and `newStringUTF8NoRepl`, the change for constructor is 
>>> from SO.
>> 
>> I don't know how we can progress this PR if the patch includes code copied 
>> from SO. Maybe the PR should be closed, the JBS issue unassigned, and leave 
>> it to someone else to start again? Maybe you could get Amit to sign the OCA 
>> and you co-contribute/author the PR? I can't look at the patch so I don't 
>> know how significant the changes, maybe there are other options.
>
> @AlanBateman I suggest to decide first whether this should be fixed on 
> HotSpot level (which is the best option to me) or on Java level.
> 
> If we choose HotSpot then the issue should be reassigned, because I cannot do 
> the fix myself.
> 
> If we choose Java then I would revert the change for String constructor and 
> Amir would commit it into this branch having OCA signed.
> 
> What do you think?

@stsypanov I just looked at the generated code and make a guess, which may be 
not entirely true though. I think you could ask hotspot compiler mailing list 
for more profound analysis.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6812

Reply via email to