On Fri, 11 Feb 2022 02:38:08 GMT, Athijegannathan Sundararajan
<[email protected]> wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review comment
>
> src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java line 58:
>
>> 56: * will fail.
>> 57: */
>> 58: public abstract class NativeLibraries {
>
> could this be sealed with only two specific subtypes defined here?
It could. It's just an internal class and not so much of a concern of
unexpected subclasses. I'll leave it as is.
> src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java line 251:
>
>> 249: // do not search java.library.path
>> 250: super(loader, loader != null ? null : NativeLibraries.class,
>> 251: loader != null ? true : false);
>
> The last argument expression of the super class could be just loader != null
Updated. Thanks.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7435
