On Tue, 15 Feb 2022 22:31:28 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> src/java.base/share/classes/java/text/CompactNumberFormat.java line 595:
>> 
>>> 593:                 divisor = (Long) divisors.get(++compactDataIndex);
>>> 594:                 iPart = getIntegerPart(number, divisor);
>>> 595:             }
>> 
>> This and the few lines surrounding it were duplicated. Might be worth 
>> considering consolidation.
>
> Right. In fact, I tried to converge them but ended up not to, as there are 
> slight differences for each number type.

Yeah, that's fine.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7412

Reply via email to