On Tue, 15 Feb 2022 15:48:02 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8279995: jpackage --add-launcher option should allow overriding 
>> description [v3]
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/WindowsHelper.java line 159:
> 
>> 157:         }
>> 158: 
>> 159:         TKit.assertNotNull(description, "Failed to get file 
>> description");
> 
> Failure to get the executable's description through powersehll script is not 
> an issue of a test case being executed. This is the testing framework issue. 
> Throwing RuntimeException with the message containing file path will be the 
> appropriate error handling. Having a file name in the exception message will 
> help to localize the issue.

Fixed. Error message also fixed for description check.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7399

Reply via email to