On Wed, 23 Feb 2022 18:22:53 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - implement review comments >> - copyright years > > test/jdk/java/util/Properties/PropertiesStoreTest.java line 51: > >> 49: * @summary tests the order in which the Properties.store() method >> writes out the properties >> 50: * @bug 8231640 8282023 >> 51: * @modules jdk.localedata > > OK, you can remove `@modules jdk.localedata` so that other tests would run. > (it'd be unusual setup, but still possible with jlink) Thank you Naoto. I've removed this in the latest version of the PR. > test/jdk/java/util/Properties/PropertiesStoreTest.java line 60: > >> 58: // it internally calls the Date.toString() which always writes in a >> locale insensitive manner >> 59: private static final DateTimeFormatter formatter = >> DateTimeFormatter.ofPattern(DATE_FORMAT_PATTERN) >> 60: .withLocale(Locale.ROOT); > > Should have noticed before, but you can call the convenient overload of > `ofPattern(DATE_FORMAT_PATTERN, Locale.ROOT)` here. Applies to the other test > too. That makes sense. I hadn't noticed that API before. I've updated the PR with this suggested change. ------------- PR: https://git.openjdk.java.net/jdk/pull/7558
