On Tue, 1 Mar 2022 02:22:49 GMT, Quan Anh Mai <d...@openjdk.java.net> wrote:

>> Hi,
>> 
>> `Objects.requireNonNull` may fail to be inlined. The call is expensive and 
>> may lead to objects escaping to the heap while the null check is cheap and 
>> is often elided. I have observed this when using the vector API when a call 
>> to `Objects.requireNonNull` leads to vectors being materialised in a hot 
>> loop.
>> 
>> Should the other `requireNonNull` be `ForceInline` as well?
>> 
>> Thank you very much.
>
> Quan Anh Mai has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   the other

I have applied the change for the other one as well. Thanks a lot.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7543

Reply via email to