On Tue, 15 Mar 2022 08:17:24 GMT, Ioi Lam <ik...@openjdk.org> wrote:

>> This patch makes the result of "java -Xshare:dump" deterministic:
>> - Disabled new Java threads from launching. This is harmless. See comments 
>> in jvm.cpp
>> - Fixed a problem in hashtable ordering in heapShared.cpp
>> - BasicHashtableEntry has a gap on 64-bit platforms that may contain random 
>> bits. Added code to zero it.
>> - Enabled checking of $JAVA_HOME/lib/server/classes.jsa in 
>> make/scripts/compare.sh
>> 
>> Note:  $JAVA_HOME/lib/server/classes_ncoops.jsa is still non-deterministic. 
>> This will be fixed in 
>> [JDK-8282828](https://bugs.openjdk.java.net/browse/JDK-8282828).
>> 
>> Testing under way:
>> - tier1~tier5
>> - Run all *-cmp-baseline jobs 20 times each (linux-aarch64-cmp-baseline, 
>> windows-x86-cmp-baseline, .... etc).
>
> Ioi Lam has updated the pull request with a new target base due to a merge or 
> a rebase. The incremental webrev excludes the unrelated changes brought in by 
> the merge/rebase. The pull request contains 12 additional commits since the 
> last revision:
> 
>  - fixed copyright
>  - Merge branch 'master' into 
> 8253495-cds-generateds-non-deterministic-output-2
>  - @calvinccheung review: fixed typo
>  - Added helper function CollectedHeap::zap_filler_array_with
>  - @kimbarrett comments
>  - zero GC heap filler arrays
>  - improvement zeroing of alignment gaps
>  - Fixed zero build
>  - Merge branch 'master' into 
> 8253495-cds-generateds-non-deterministic-output-2
>  - fixed test
>  - ... and 2 more: 
> https://git.openjdk.java.net/jdk/compare/1ab17a39...cd934f3c

Build changes look good.

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7748

Reply via email to