On Sat, 12 Mar 2022 01:26:24 GMT, Yasser Bazzi <d...@openjdk.java.net> wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default method `asRandom()` that wraps around the >> newer algorithms to be used on classes that do not accept the new interface. >> >> Some things to note as proposed by the bug report, the protected method >> next(int bits) is not overrided and setSeed() method if left blank up to >> discussion on what to do with it. >> >> Small test done on >> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4 > > Yasser Bazzi has updated the pull request incrementally with one additional > commit since the last revision: > > make changes proposed OK, I ran our test suite and found that SplittableRandomTest failed. Please merge in the fix from the latest commit on this branch: https://github.com/stuart-marks/jdk/commits/pull/7001 With this fix in place I get a clean test run. ------------- PR: https://git.openjdk.java.net/jdk/pull/7001
