On Thu, 17 Mar 2022 08:44:57 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> src/java.base/share/native/libverify/check_code.c line 472: >> >>> 470: >>> 471: static void check_and_push(context_type *context, void *ptr, int kind); >>> 472: static void check_and_push_const(context_type *context, const void >>> *ptr, int kind); >> >> This really needs a comment explaining why two functions are needed. > > I think it would be clearer to drop the kind argument and have two functions > check_and_push_vm_string(context_type*, const char*) > check_and_push_malloc_block(context_type*, void*) > with a shared helper that is given the appropriate kind. I had that at some point and then dropped it. I don't know why and it does seem like the better option so I'll try it again. ------------- PR: https://git.openjdk.java.net/jdk/pull/7794
