On Mon, 28 Mar 2022 07:43:29 GMT, Jie Fu <ji...@openjdk.org> wrote: >> Xiaohong Gong has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add a superclass for vector negation > > src/hotspot/share/opto/vectornode.cpp line 1592: > >> 1590: >> 1591: // Generate other vector nodes to implement the masked/non-masked >> vector negation. >> 1592: Node* VectorNode::degenerate_vector_integral_negate(Node* n, int vlen, >> BasicType bt, PhaseGVN* phase, bool is_predicated) { > > Shall we move this declaration in `class NegVNode` since it is only used by > NegVNode::Ideal ?
I think it can be. Thanks for pointing out this. I will change this later. ------------- PR: https://git.openjdk.java.net/jdk/pull/7782