On Wed, 6 Apr 2022 13:36:05 GMT, Alexey Ivanov <[email protected]> wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert liblcms changes
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties
> line 63:
>
>> 61: message.creating-association-with-null-extension=Creating association
>> with null extension.
>> 62: message.wrong-tool-version=Detected [{0}] version {1} but version {2} is
>> required.
>> 63: message.version-string-too-many-components=Version string may have up to
>> 3 components - major.minor.build .
>
> I wonder whether the space before the period is required at the end of the
> sentence. Perhaps, it's to separate a property name from the end of the
> sentence.
right; without the space the period would appear to be part of the version
pattern.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8125