On Fri, 8 Apr 2022 13:11:23 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

>> Volker Simonis has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Added API-refinement to GZIPInputStream::read()/ZipInputStream::read() and 
>> an Implementation note to ZipFile::getInputStream()
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 346:
> 
>> 344:      * have been returned by invocations of this method.
>> 345:      *
>> 346:      * @implNote In the JDK implementation this method returns an
> 
> The "In the JDK implementation" sounds a bit odd to me. I looked around some 
> other `@implNote`s and many of of them use `@implNote This implementation 
> ....`, so perhaps we should change this to:
> ``` 
> @implNote This implementation returns an instance of {@link 
> java.util.zip.InflaterInputStream}.

Thanks for the suggestion. I've updated to code accordingly.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7986

Reply via email to