On Sat, 9 Oct 2021 17:01:16 GMT, XenoAmess <d...@openjdk.java.net> wrote:
>> You should really post your changes to jdk-dev at openjdk.java.net before >> submitting these so you can know if a change is potentially good or bad. >> Since jdk pull requests require issue numbers, you can ask people on the >> list if this is a good idea; if it is, someone on the list may create an >> issue for you, which probably means your suggestion is valid, and only then >> you should send a pull request. > >> You should really post your changes to jdk-dev at openjdk.java.net before >> submitting these so you can know if a change is potentially good or bad. >> Since jdk pull requests require issue numbers, you can ask people on the >> list if this is a good idea; if it is, someone on the list may create an >> issue for you, which probably means your suggestion is valid, and only then >> you should send a pull request. > > you mean I should pin the patch file at mailing list first? Get it. > > I just think it easier to view the code changes at github pr page than the > patch file...but if the workflow should be asking at the mailing list first, > then I will obey. > @XenoAmess This pull request has been inactive for more than 4 weeks and will > be automatically closed if another 4 weeks passes without any activity. To > avoid this, simply add a new comment to the pull request. Feel free to ask > for assistance if you need help with progressing this pull request towards > integration! help needed. ------------- PR: https://git.openjdk.java.net/jdk/pull/5872
