On Tue, 12 Apr 2022 22:19:18 GMT, XenoAmess <d...@openjdk.java.net> wrote:
>> @jmehrens what about this then? >> I think it safe now(actually this mechanism is learned from Reader) > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > add MIN_SKIP_BUFFER_SIZE src/java.base/share/classes/java/io/InputStream.java line 557: > 555: > 556: while (remaining > 0) { > 557: nr = read(skipBuffer, 0, (int)Math.min(size, remaining)); I recommend moving `nr` declaration from the beginning of the method to where it's actually used (here) ------------- PR: https://git.openjdk.java.net/jdk/pull/5872