On Wed, 13 Apr 2022 08:30:33 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:

>>> Hello @shipilev, do you think this stackless nature of this specific 
>>> `DatatypeException` type should be noted in its javadoc, just to avoid any 
>>> surprises when someone in future ends up using this exception type as the 
>>> "cause" of some other exception?
>> 
>> I don't think so. It seems to me the intent for these exceptions is to carry 
>> error information without any stack trace info.
>
>> @shipilev
>> 
>> > Any other reviews? I would like someone else to confirm my investigation 
>> > that we don't use the stack traces out of these exceptions too...
>> 
>> I opened [XERCESJ‑1742](https://issues.apache.org/jira/browse/XERCESJ-1742) 
>> to get this change upstreamed into **Xerces**, the resolution of which 
>> should also answer your question about whether the stack traces are really 
>> unused.
> 
> Thanks! But I see there seem to be no upstream interest yet. So I am planning 
> to integrate this to JDK first, and so asking for JDK-specific reviews again.

> > Hello @shipilev, do you think this stackless nature of this specific 
> > `DatatypeException` type should be noted in its javadoc, just to avoid any 
> > surprises when someone in future ends up using this exception type as the 
> > "cause" of some other exception?
> 
> I don't think so. It seems to me the intent for these exceptions is to carry 
> error information without any stack trace info.

Looks fine to me then. However, I'm not a Reviewer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8036

Reply via email to