On Thu, 14 Apr 2022 21:39:17 GMT, Paul Sandoz <psan...@openjdk.org> wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh
>
> src/java.base/share/classes/java/lang/Thread.java line 862:
>
>> 860: * @param start the starting value of the counter
>> 861: * @return this builder
>> 862: * @throws IllegalArgumentException if count is negative
>
> Suggestion:
>
> * @throws IllegalArgumentException if start is negative
Thanks, I think that dates from when the param was renamed.
> src/java.base/share/classes/java/lang/VirtualThread.java line 65:
>
>> 63: * system.
>> 64: */
>> 65: class VirtualThread extends Thread {
>
> Suggestion:
>
> final class VirtualThread extends Thread {
okay.
> src/java.base/share/classes/java/lang/VirtualThread.java line 94:
>
>> 92: * RUNNING -> PARKING // Thread attempts to park
>> 93: * PARKING -> PARKED // yield successful, thread is parked
>> 94: * PARKING -> PINNED // yield failed, thread is pinned
>
> Suggestion:
>
> * PARKING -> PARKED // parking successful, thread is parked
> * PARKING -> PINNED // parking failed, thread is pinned
The comment was about cont.yield, will change it to make it clearer.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8166
