On Fri, 15 Apr 2022 05:58:32 GMT, liach <d...@openjdk.java.net> wrote:

> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare 
> values by identity. Updated API documentation of these two methods 
> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Object,java.lang.Object)))
>  to mention such behavior.

Thanks for working on this. Yes I can review and sponsor this change.

Sorry I got a bit distracted. I started looking at the test here, and this lead 
me to inquire about what other tests we have for `IdentityHashMap`, and the 
answer is: not enough. See 
[JDK-8285295](https://bugs.openjdk.java.net/browse/JDK-8285295). (But that 
should be handled separately.)

-------------

PR: https://git.openjdk.java.net/jdk/pull/8259

Reply via email to