On Fri, 29 Apr 2022 06:09:35 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e > > test/hotspot/jtreg/serviceability/jvmti/events/Breakpoint/breakpoint01/libbreakpoint01.cpp > line 139: > >> 137: thr_info.name, (jni->IsVirtualThread(thread) == >> JNI_TRUE) ? "virtual" : "kernel", >> 138: (thr_info.is_daemon == JNI_TRUE) ? "deamon" : "user"); >> 139: } > > I'd suggest to add locals (their names are up to you): > const char* thr_virtual_tag = jni->IsVirtualThread(thread) == JNI_TRUE ? > "virtual" : "kernel"; > const char* thr_daemon_tag == JNI_TRUE) ? "deamon" : "user"; > > It is better to place togeter lines: 129+130. > Line 137 is not aligned, and there are many unneeded spaces. > The '()' around conditions are not needed. At least, I do not see them > increasing readability. fixed ------------- PR: https://git.openjdk.java.net/jdk/pull/8166
