> Currently we set _WIN32_WINNT at various places in the codebase; this is used 
> to target a minimum Windows version we want to support. See also for more 
> detailled information :
> https://docs.microsoft.com/en-us/windows/win32/winprog/using-the-windows-headers?redirectedfrom=MSDN#setting-winver-or-_win32_winnt
> Macros for Conditional Declarations
> "Certain functions that depend on a particular version of Windows are 
> declared using conditional code. This enables you to use the compiler to 
> detect whether your application uses functions that are not supported on its 
> target version(s) of Windows."
> 
> However currently we have quite a lot of differing settings of _WIN32_WINNT 
> in the codebase ; setting _WIN32_WINNT to 0x0601 (Windows 7) where possible 
> would make sense because we have this setting already at   java_props_md.c  
> (so targeting older Windows versions at other places is most likely not 
> useful).

Matthias Baesken has updated the pull request incrementally with one additional 
commit since the last revision:

  set _WIN32_WINNT=0x0601 centrally in flags-cflags.m4

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8428/files
  - new: https://git.openjdk.java.net/jdk/pull/8428/files/aef2486f..dff223c5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8428&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8428&range=00-01

  Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8428.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8428/head:pull/8428

PR: https://git.openjdk.java.net/jdk/pull/8428

Reply via email to